[PATCH] D20237: Use printAliasInstr in ARM target

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Fri May 20 05:51:26 PDT 2016


rengolin added a comment.

Hi Roger,

Sorry, that completely slipped through the net. Thanks for the ping.

This change looks good, but the flag name "Emit" seems dubious. It creates the idea, just by looking at the table-gen, that all the other aliases don't need to be emitted. Now that it's being used more widely, a more expressive name would help understand its real purpose?

cheers,
--renato


http://reviews.llvm.org/D20237





More information about the llvm-commits mailing list