[PATCH] D20452: Allow -inline-threshold to override default (explicitly specified/derived from opt levels) threshold

[Easwaran Raman via llvm-commits]

eraman added inline comments.

================
Comment at: lib/Analysis/InlineCost.cpp:624-627
@@ -623,2 +623,6 @@
       Threshold = OptSizeThreshold;
+  } else {
+    // Explicitly specified -inline-threhold overrides the threshold passed to
+    // CallAnalyzer's constructor.
+    Threshold = DefaultInlineThreshold;
   }
----------------
chandlerc wrote:
> How about reversing the condition above? It seems much more natural to write
> 
>   if (/* we have an explicit option */) {
>     // use it...
>   } else {
>     // use the thresholds
>   }
I've reversed the condition and also moved the comment at line 616 near the relevant code.


Repository:
  rL LLVM

http://reviews.llvm.org/D20452