[PATCH] D20409: [LibFuzzer] Fix NumberOfCpuCores() for Mac OSX

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Thu May 19 16:08:03 PDT 2016


delcypher added inline comments.

================
Comment at: lib/Fuzzer/FuzzerUtil.cpp:140
@@ -121,1 +139,3 @@
+  }
+  assert(N > 0 && "Number of cpu cores must be > 0");
   return N;
----------------
kcc wrote:
> with the default N = 1 you can just remove this. 
If the command returns the string "0" then N will still get set to 0 regardless of the default which means the assert is still needed.


http://reviews.llvm.org/D20409





More information about the llvm-commits mailing list