[llvm] r269977 - [x86] add test for immediate comment formatting

Thu May 19 13:42:32 PDT 2016

Hi Mike -

Yep, I accidentally uncovered a bug. I've posted a patch for review here:
http://reviews.llvm.org/D20434

Would it be better to comment out the offending line of the test until the
patch is reviewed?

On Thu, May 19, 2016 at 2:10 PM, Mike Aizatsky <aizatsky at google.com> wrote:

> Sanjay,
>
> I think this breaks sanitizer build:
>
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/12914
>
> /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/MC/MCExpr.cpp:667:26:
> runtime error: negation of -9223372036854775808 cannot be represented in
> type 'int64_t' (aka 'long'); cast to an unsigned type to negate this value
> to itself
>     #0 0x85272a in llvm::MCExpr::evaluateAsRelocatableImpl(llvm::MCValue&,
> llvm::MCAssembler const*, llvm::MCAsmLayout const*, llvm::MCFixup const*,
> llvm::DenseMap<llvm::MCSection const*, unsigned long,
> llvm::DenseMapInfo<llvm::MCSection const*>,
> llvm::detail::DenseMapPair<llvm::MCSection const*, unsigned long> > const*,
> bool) const
> /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/MC/MCExpr.cpp:667:26
>     #1 0x851e04 in llvm::MCExpr::evaluateAsAbsolute(long&,
> llvm::MCAssembler const*, llvm::MCAsmLayout const*,
> llvm::DenseMap<llvm::MCSection const*, unsigned long,
> llvm::DenseMapInfo<llvm::MCSection const*>,
> llvm::detail::DenseMapPair<llvm::MCSection const*, unsigned long> > const*,
> bool) const
> /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/MC/MCExpr.cpp:439:7
>     #2 0x8b5e5a in (anonymous
> namespace)::AsmParser::parseExpression(llvm::MCExpr const*&, llvm::SMLoc&)
> /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/MC/MCParser/AsmParser.cpp:1095:7
>     #3 0x5d74bd in (anonymous namespace)::X86AsmParser::ParseATTOperand()
> /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1908:9
>     #4 0x5d4b54 in (anonymous namespace)::X86AsmParser::ParseOperand()
> /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1137:10
>     #5 0x5cd0da in (anonymous
> namespace)::X86AsmParser::ParseInstruction(llvm::ParseInstructionInfo&,
> llvm::StringRef, llvm::SMLoc,
> llvm::SmallVectorImpl<std::unique_ptr<llvm::MCParsedAsmOperand,
> std::default_delete<llvm::MCParsedAsmOperand> > >&)
> /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:2319:44
>     #6 0x8ba751 in (anonymous
> namespace)::AsmParser::parseStatement((anonymous
> namespace)::ParseStatementInfo&, llvm::MCAsmParserSemaCallback*)
> /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/MC/MCParser/AsmParser.cpp:1771:19
>     #7 0x8b2c02 in (anonymous namespace)::AsmParser::Run(bool, bool)
> /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/MC/MCParser/AsmParser.cpp:675:10
>     #8 0x43dbdc in AssembleInput(char const*, llvm::Target const*,
> llvm::SourceMgr&, llvm::MCContext&, llvm::MCStreamer&, llvm::MCAsmInfo&,
> llvm::MCSubtargetInfo&, llvm::MCInstrInfo&, llvm::MCTargetOptions&)
> /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/tools/llvm-mc/llvm-mc.cpp:352:13
>     #9 0x43c595 in main
> /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/tools/llvm-mc/llvm-mc.cpp:523:11
>     #10 0x7fc83364fec4 in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x21ec4)
>     #11 0x41b5fd in _start
> (/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm_build_ubsan/bin/llvm-mc+0x41b5fd)
>
>
> On Wed, May 18, 2016 at 1:32 PM Sanjay Patel via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: spatel
>> Date: Wed May 18 15:26:32 2016
>> New Revision: 269977
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=269977&view=rev
>> Log:
>> [x86] add test for immediate comment formatting
>>
>> Added:
>>     llvm/trunk/test/MC/X86/imm-comments.s
>>
>> Added: llvm/trunk/test/MC/X86/imm-comments.s
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/X86/imm-comments.s?rev=269977&view=auto
>>
>> ==============================================================================
>> --- llvm/trunk/test/MC/X86/imm-comments.s (added)
>> +++ llvm/trunk/test/MC/X86/imm-comments.s Wed May 18 15:26:32 2016
>> @@ -0,0 +1,26 @@
>> +# RUN: llvm-mc %s -triple=x86_64-unknown-unknown | FileCheck %s
>> +
>> +movb  $127, %al
>> +movb  $-128, %al
>> +
>> +movw  $32767, %ax
>> +movw  $-32768, %ax
>> +
>> +movl  $2147483647, %eax
>> +movl  $-2147483648, %eax
>> +
>> +movabsq        $9223372036854775807, %rax
>> +movabsq        $-9223372036854775808, %rax
>> +
>> +# CHECK:  movb  $127, %al
>> +# CHECK:  movb  $-128, %al
>> +
>> +# CHECK:  movw  $32767, %ax             # imm = 0x7FFF
>> +# CHECK:  movw  $-32768, %ax            # imm = 0xFFFFFFFFFFFF8000
>> +
>> +# CHECK:  movl  $2147483647, %eax       # imm = 0x7FFFFFFF
>> +# CHECK:  movl  $-2147483648, %eax      # imm = 0xFFFFFFFF80000000
>> +
>> +# CHECK:  movabsq $9223372036854775807, %rax # imm = 0x7FFFFFFFFFFFFFFF
>> +# CHECK:  movabsq $-9223372036854775808, %rax # imm = 0x8000000000000000
>> +
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
> --
> Mike
> Sent from phone
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160519/00309b6f/attachment.html>