[PATCH] D20384: Refactor 1 symbol record

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Thu May 19 12:58:17 PDT 2016


zturner updated this revision to Diff 57844.
zturner added a comment.

This refactors all the symbol records as discussed offline.  The code got shorter in some places, but more verbose in others, as now every case of the switch statement has to repeat the same 5-6 lines of code to try the deserialization.

This is just a stepping stone to introducing a symbol visitor however, and once we have this will become much simpler.  I didn't want to do too much in one patch though, so that will come in a followup


http://reviews.llvm.org/D20384

Files:
  include/llvm/DebugInfo/CodeView/RecordSerialization.h
  include/llvm/DebugInfo/CodeView/SymbolRecord.h
  lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
  tools/llvm-readobj/COFFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20384.57844.patch
Type: text/x-patch
Size: 74999 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160519/971cfbc0/attachment.bin>


More information about the llvm-commits mailing list