[PATCH] D20431: [llvm-nm] Fix output for Mach-O universal files wrapping bitcode objects

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Thu May 19 12:14:40 PDT 2016


- Phab for a drive-by comment:

> On May 19, 2016, at 9:49 AM, Kevin Enderby via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Looks fine to me.
> 
> There is a whole bunch of better error handling that still needs to happen, I’m grinding through adding all of that

There's a new `message()` method in ErrorInfoBase that could help with this effort.

At least, it helps avoid the logAllUnhandledErrors(std::move(E)) pattern. I found that this made transitioning parts of ProfileData to Error/Expected much easier.

vedant


More information about the llvm-commits mailing list