[PATCH] D16311: [AVR] Add AVRTargetStreamers

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu May 19 10:39:00 PDT 2016


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with comment fixes + makefile dropped


================
Comment at: lib/Target/AVR/MCTargetDesc/AVRELFStreamer.h:17-19
@@ +16,5 @@
+
+/**
+ * A target streamer for an AVR ELF object file.
+ */
+class AVRELFStreamer : public AVRTargetStreamer {
----------------
C++ style comments

================
Comment at: lib/Target/AVR/MCTargetDesc/AVRTargetStreamer.h:16-18
@@ +15,5 @@
+
+/**
+ * A generic AVR target output stream.
+ */
+class AVRTargetStreamer : public MCTargetStreamer {
----------------
Ditto

================
Comment at: lib/Target/AVR/MCTargetDesc/Makefile:1-16
@@ +1,16 @@
+##===- lib/Target/AVR/TargetDesc/Makefile ------------------*- Makefile -*-===##
+#
+#                     The LLVM Compiler Infrastructure
+#
+# This file is distributed under the University of Illinois Open Source
+# License. See LICENSE.TXT for details.
+#
+##===----------------------------------------------------------------------===##
+
+LEVEL = ../../../..
+LIBRARYNAME = LLVMAVRDesc
+
+# Hack: we need to include 'main' target directory to grab private headers
+CPP.Flags += -I$(PROJ_OBJ_DIR)/.. -I$(PROJ_SRC_DIR)/..
+
+include $(LEVEL)/Makefile.common
----------------
Not necessary anymore


http://reviews.llvm.org/D16311





More information about the llvm-commits mailing list