[PATCH] D20286: [Coverage] Fix an issue where improper coverage mapping data could be loaded for an inline function.

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: lib/ProfileData/Coverage/CoverageMappingReader.cpp:351
@@ +350,3 @@
+  if (Hash) {
+    Result = false;
+    return Error::success();
----------------
Should this be moved above the if(Hash) so that caller does not need to initialize it.

================
Comment at: test/tools/llvm-cov/Inputs/prefer_used_to_unused.cpp:5
@@ +4,2 @@
+  return sampleFunc(5) + simpleFunc(5);
+}
----------------
do you need another source file that includes prefer_used_to_unused.h but does not call sampleFunc nor simpleFunc in order to force creation of dummies?


http://reviews.llvm.org/D20286