[PATCH] D19268: [DAGCombiner] Do not remove the load of stored values when optimizations are disabled

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Thu May 19 09:12:02 PDT 2016


qcolombet added a comment.

Hi Marianne,

Given the feedback on the other thread, yes, please carry on with the current approach.

Couple of comments inlined.

Cheers,
-Quentin


================
Comment at: test/CodeGen/ARM/dag-combine-ldst.ll:12
@@ +11,3 @@
+define i32 @main() #0 {
+  %1 = alloca i32, align 4
+  %2 = alloca i32, align 4
----------------
Run opt -instnamer on the test case to get rid of the [0-9]+ variables.

================
Comment at: test/CodeGen/ARM/dag-combine-ldst.ll:35
@@ +34,1 @@
+}
\ No newline at end of file

----------------
Add a newline.


Repository:
  rL LLVM

http://reviews.llvm.org/D19268





More information about the llvm-commits mailing list