[PATCH] D20423: [Clang][LLVMGold] Passing LLVM arguments to gold plugin

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu May 19 06:11:27 PDT 2016


tejohnson added inline comments.

================
Comment at: lib/Driver/Tools.cpp:8371
@@ +8370,3 @@
+    for (const Arg *A : Args.filtered(options::OPT_mllvm)) {
+        CmdArgs.push_back(Args.MakeArgString("-plugin-opt=" + StringRef(A->getValue(0))));
+    }
----------------
Should be moved to AddGoldPlugin called just above.

Seems reasonable to pass these along to the plugin, rather than require the user to know to pass them via -Wl,-plugin-opt.


http://reviews.llvm.org/D20423





More information about the llvm-commits mailing list