[PATCH] D20268: [wip] Resolution-based LTO API.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed May 18 13:03:55 PDT 2016


pcc added inline comments.

================
Comment at: include/llvm/LTO/LTO.h:39
@@ +38,3 @@
+  typedef std::function<void(std::unique_ptr<raw_pwrite_stream>)> FinishFn;
+  FinishFn Finish;
+
----------------
rafael wrote:
> Is this being used?
Not just yet. I've removed it (and this class).

================
Comment at: include/llvm/LTO/LTO.h:42
@@ +41,3 @@
+  template <typename S>
+  LTONativeObjectStream(std::unique_ptr<S> OS)
+      : OS(std::move(OS)) {}
----------------
rafael wrote:
> make the constructor explicit.
Removed


http://reviews.llvm.org/D20268





More information about the llvm-commits mailing list