[PATCH] D20260: IR: Introduce local_unnamed_addr attribute.

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 21:50:16 PDT 2016


Rafael EspĂ­ndola via llvm-commits <llvm-commits at lists.llvm.org> writes:
> On 17 May 2016 at 20:08, Mehdi Amini <mehdi.amini at apple.com> wrote:
>> Seriously I absolutely don't get the "start a new revision" thing
>> because the initial email was not on llvm-commit. Really what is the
>> rational?
>>
>> We are losing the history and the threading for the review, this is
>> really annoying.
>>
>> So big -1
>
> I agree with Mehdi on this one.
>
> Having to remember to include llvm-commits every time we use phab is
> really annoying. If that means that we have to start a new thread in
> the middle of a code review every time we forget I think we should
> just not use phab.

I'm fine with that, but I understand some people find phab helpful.


More information about the llvm-commits mailing list