[PATCH] D20260: IR: Introduce local_unnamed_addr attribute.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 16:08:09 PDT 2016


pcc marked 2 inline comments as done.
pcc added a comment.

> You might want to add a case to compatibility.ll too.


Done.


================
Comment at: docs/BitCodeFormat.rst:727
@@ -722,2 +726,3 @@
   variable:
+
   * ``not thread local``: code 0
----------------
rafael wrote:
> What are the white space changes? Can you commit them first if it is a cleanup?
Yes, r269857.

================
Comment at: docs/BitCodeFormat.rst:836
@@ -822,1 +835,3 @@
 
+* *threadlocal*: If present, an encoding of the
+  :ref:`thread local property<bcthreadlocal>` of the alias
----------------
rafael wrote:
> Can you commit these first? (they LGTM).
As above


http://reviews.llvm.org/D20260





More information about the llvm-commits mailing list