[PATCH] D19908: [X86] Support the "ms-hotpatch" attribute.

Charles Davis via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 12:36:43 PDT 2016

cdavis5x marked an inline comment as done.

Comment at: lib/CodeGen/PatchableFunction.cpp:43
@@ -42,3 +42,3 @@
   if (!MF.getFunction()->hasFnAttribute("patchable-function"))
     return false;
rnk wrote:
> sanjoy wrote:
> > I presume you're handling the x86-64 case here?  If so, how about handling both the 32bit and 64bit case here?  On 32 bits, you can just emit a `mov %edi, %edi` instead of a `PATCHABLE_OP`?  That way related bits stay together.
> +1
I'm not so sure about this. This looks like it's ultimately intended to be a target-independent pass. Putting target-specific code in here feels... wrong. If you really want me to do that anyway, I'll do it, but I'm just saying, I don't think that's such a good idea.


More information about the llvm-commits mailing list