[PATCH] D20332: [ThinLTO] Use semicolon to separate path prefix replacement

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 09:52:15 PDT 2016


tejohnson added a comment.

Thanks, Reid! Noted a couple of other places that need fix. Also test/tools/gold/X86/thinlto_prefix_replace.ll needs the same option change.


================
Comment at: tools/gold/gold-plugin.cpp:1223
@@ -1222,3 +1222,3 @@
   assert(PrefixReplace.empty() || PrefixReplace.find(":") != StringRef::npos);
   std::pair<StringRef, StringRef> Split = PrefixReplace.split(":");
   OldPrefix = Split.first.str();
----------------
The above 2 lines need changing as well.

================
Comment at: tools/llvm-lto/llvm-lto.cpp:111
@@ -110,3 +110,3 @@
     cl::desc("Control where files for distributed backends are "
              "created. Expects 'oldprefix:newprefix' and if path "
              "prefix of output file is oldprefix it will be "
----------------
Description needs update.


http://reviews.llvm.org/D20332





More information about the llvm-commits mailing list