[PATCH] D20331: [llvm-mc] - Teach llvm-mc to generate compressed debug sections in zlib style.

[Davide Italiano via llvm-commits]

davide added inline comments.

================
Comment at: lib/MC/ELFObjectWriter.cpp:576
@@ -575,4 +575,3 @@
   auto &Sec = cast<MCSectionELF>(Sym->getSection());
-  unsigned Flags = Sec.getFlags();
-  if (Flags & ELF::SHF_MERGE) {
+  if (Sec.Flags & ELF::SHF_MERGE) {
     if (C != 0)
----------------
Why do you need to change this?

================
Comment at: lib/MC/MCSectionELF.cpp:164
@@ -165,4 +163,2 @@
 
-bool MCSectionELF::isVirtualSection() const {
-  return getType() == ELF::SHT_NOBITS;
-}
+bool MCSectionELF::isVirtualSection() const { return Flags == ELF::SHT_NOBITS; }
----------------
Why did you change from `getType()` to `Flags`. Also, why can't you use the getter as they were used before?


http://reviews.llvm.org/D20331