[PATCH] D20143: New pass: guard widening

[Philip Reames via llvm-commits]

reames added a comment.

Sanjoy and I talked about this one offline and I wanted to highlight a key point which is not obvious from the review thread:

This code is not intended to be long term solution to guard widening.  This is essentially an experimental piece of code whose purposes is to inform what real optimization passes need to be extended to handle the majority of cases which arrive in practice.  It was deliberately designed to be simple and effective at the cost of compile time.

My own review was from the perspective of this being a "real" optimization pass.  I don't know if we have a history of landing and evolving such experimental pieces of code in tree.  I certainly wouldn't feel comfortable approving such a thing since I have a clear conflict of interest, but I'm also not opposed to the notion either.

What do others think?  Is having a pass that is expected to be experimental and unlikely to survive in its current form in tree a good idea?


http://reviews.llvm.org/D20143