[PATCH] D19659: [X86] Enable RRL part of the LEA optimization pass for -O2

[Quentin Colombet via llvm-commits]

qcolombet added inline comments.

================
Comment at: test/CodeGen/X86/lea-opt.ll:1
@@ -1,2 +1,2 @@
 ; RUN: llc < %s -mtriple=x86_64-linux | FileCheck %s
 
----------------
Could you check both with and without the optimization running?

================
Comment at: test/CodeGen/X86/lea-opt.ll:112
@@ -113,1 +111,3 @@
+  %cvt = ptrtoint i32* %b to i32
+  store i32 %cvt, i32* %b, align 4
   br label %sw.epilog
----------------
I don’t get what is the problem with that specific part of the test.

If we want to test something else, writing a new test should be fine instead of fixing that one, shouldn’t it?


http://reviews.llvm.org/D19659