[PATCH] D20263: X86: Avoid using _chkstk when lowering WIN_ALLOCA instructions

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 15:50:48 PDT 2016


mkuper added inline comments.

================
Comment at: lib/Target/X86/X86WinAllocaExpander.cpp:50
@@ +49,3 @@
+  /// Compute which lowering to use for each WinAlloca instruction.
+  LoweringMap computeLowerings(MachineFunction &MF);
+
----------------
DavidKreitzer wrote:
> Do you really want to return a LoweringMap? This will cause the entire container to be copied. Maybe pass in a LoweringMap& and fill it in instead?
Won't this be ok with RVO?


http://reviews.llvm.org/D20263





More information about the llvm-commits mailing list