[PATCH] D20268: [wip] Resolution-based LTO API.

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 12:46:17 PDT 2016


rafael added inline comments.

================
Comment at: include/llvm/LTO/LTO.h:39
@@ +38,3 @@
+  typedef std::function<void(std::unique_ptr<raw_pwrite_stream>)> FinishFn;
+  FinishFn Finish;
+
----------------
Is this being used?

================
Comment at: include/llvm/LTO/LTO.h:42
@@ +41,3 @@
+  template <typename S>
+  LTONativeObjectStream(std::unique_ptr<S> OS)
+      : OS(std::move(OS)) {}
----------------
make the constructor explicit.


http://reviews.llvm.org/D20268





More information about the llvm-commits mailing list