[llvm] r269678 - [BasicAA] Update comments based on feedback from hfinkel. NFCI.

Geoff Berry via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 11:51:54 PDT 2016


Author: gberry
Date: Mon May 16 13:51:54 2016
New Revision: 269678

URL: http://llvm.org/viewvc/llvm-project?rev=269678&view=rev
Log:
[BasicAA] Update comments based on feedback from hfinkel. NFCI.

Original change Hal's comments were based on:
http://reviews.llvm.org/D19730

Modified:
    llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp

Modified: llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp?rev=269678&r1=269677&r2=269678&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp (original)
+++ llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp Mon May 16 13:51:54 2016
@@ -570,6 +570,9 @@ FunctionModRefBehavior BasicAAResult::ge
 
 /// Returns the behavior when calling the given function. For use when the call
 /// site is not known.
+/// NOTE: Because of the special case handling of llvm.assume below, the result
+/// of this function may not match similar results derived from function
+/// attributes (e.g. "readnone").
 FunctionModRefBehavior BasicAAResult::getModRefBehavior(const Function *F) {
   // If the function declares it doesn't access memory, we can't do better.
   if (F->doesNotAccessMemory())
@@ -577,7 +580,7 @@ FunctionModRefBehavior BasicAAResult::ge
 
   // While the assume intrinsic is marked as arbitrarily writing so that
   // proper control dependencies will be maintained, it never aliases any
-  // particular memory location.
+  // actual memory locations.
   if (F->getIntrinsicID() == Intrinsic::assume)
     return FMRB_DoesNotAccessMemory;
 




More information about the llvm-commits mailing list