[PATCH] D18827: Rework/enhance stack coloring data flow analysis.

Wei Mi via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 10:48:13 PDT 2016


wmi added inline comments.

================
Comment at: lib/CodeGen/StackColoring.cpp:164
@@ +163,3 @@
+// however, due to the fact that optimizations can sometimes
+// can sometimes migrate uses of a variable outside of its lifetime
+// start/end region. Here is an example:
----------------
repeated "can sometimes"

================
Comment at: lib/CodeGen/StackColoring.cpp:581
@@ +580,3 @@
+        if (!isStart) {
+          assert(slots.size() == 1);
+          int Slot = slots[0];
----------------
assert message missing.


http://reviews.llvm.org/D18827





More information about the llvm-commits mailing list