[PATCH] D20273: [llvm-readobj] - Teach readobj to recognize SHF_COMPRESSED flag.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 10:20:19 PDT 2016


On Mon, May 16, 2016 at 7:09 AM, George Rimar <grimar at accesssoftek.com> wrote:
> grimar added a comment.
>
> In http://reviews.llvm.org/D20273#430490, @rafael wrote:
>
>> LGTM with a testcase.
>
>
>
>
> In http://reviews.llvm.org/D20273#430522, @davide wrote:
>
>> Add a test case, please. With that, I'm fine.
>
>
> Thank you guys for review, I have a question then.
> As far I know llvm-mc do not support currently feature to generate compressed debug sections in
> zlib style (afaik, llvm-mc generates it in only zlib-gnu style, so it is not possible to emit SHF_COMPRESSED flag).
>
> So what I want to suggest here:
> what if I'll prepare patch for llvm-mc that will allow it to generate zlib style sections and after that update this one ?
> I can guess that it is a good feature for llvm-mc.
> If you would agree with above then my question would be - should we need to support both ways or can just switch
> to zlib style and cut off gnu one ? (afaik zlib-gnu is depricated in binutils).
>
> After implementing change for llvm-mc I`ll be able to prepare testcase for this. Or I can commit this one and prepare
> and commit a testcase after changes to llvm-mc, please tell me what is a acceptable way.
> (one more way would be to use pre-compiled object file for testcase right now).
>
>

I like the idea of implementing the MC bits first (this is what I did
every time there was a similar situation), so, feel free to submit a
patch.


More information about the llvm-commits mailing list