[PATCH] D20164: [mips] MIPS64R6 compact branch support

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 08:17:35 PDT 2016


dsanders requested changes to this revision.
dsanders added a reviewer: dsanders.
This revision now requires changes to proceed.

================
Comment at: lib/Target/Mips/Mips64r6InstrInfo.td:145
@@ -126,2 +144,3 @@
+/// Jump and Branch Instructions
 let isCodeGenOnly = 1 in {
 def JIALC64 : JIALC_ENC, JIALC64_DESC, ISA_MIPS64R6;
----------------
We shouldn't be using isCodeGenOnly to avoid decoder conflicts and should use DecoderNamespace instead. One thing to be careful of is that some encodings like BGEC_ENC already has a DecoderNamespace to handle the unusual shapes (such as the rs < rt conditions) in the encoding table (see DecodeDisambiguates and DecodeDisambiguatedBy).


Repository:
  rL LLVM

http://reviews.llvm.org/D20164





More information about the llvm-commits mailing list