[PATCH] D18422: Add Cache Pruning support

[NAKAMURA Takumi via llvm-commits]

Sure! We should not peek errno unless the context that calls C libraries.

On Sun, May 15, 2016 at 1:56 AM Mehdi Amini <mehdi.amini at apple.com> wrote:

>
> > On May 14, 2016, at 8:36 AM, NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
> >
> > chapuni added a subscriber: chapuni.
> >
> > ================
> > Comment at: lib/Support/CachePruning.cpp:44
> > @@ +43,3 @@
> > +  if (sys::fs::status(TimestampFile, FileStatus)) {
> > +    if (errno == ENOENT) {
> > +      // If the timestamp file wasn't there, create one now.
> > ----------------
> > Don't use errno. Fixed in r269565.
>
> Thanks!
>
> Note: this was copy/pasted from clang `void pruneModuleCache()` in
> lib/Frontend/CompilerInstance.cpp, I imagine we should fix it the same way?
>
> --
> Mehdi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160514/1e282c11/attachment.html>