[PATCH] D20268: [wip] Resolution-based LTO API.

[Mehdi AMINI via llvm-commits]

joker.eph added inline comments.

================
Comment at: include/llvm/LTO/LTO.h:25
@@ +24,3 @@
+  /// be in this linkage unit.
+  unsigned DefinitionInLinkageUnit : 1;
+
----------------
joker.eph wrote:
> Basically, does it mean we can add visibility hidden in the IR?
> And if not Prevailing, it means we can internalize?
Re-reading, it is clearly not enough for visibility hidden, we need something from the linker that tells us "this symbol is not exported outside of the linkage unit".

Also `DefinitionInLinkageUnit` would be better named `FinalDefinitionInLinkageUnit` or something that carry the fact that it is not preemptable at runtime.

For internalization, I guess that `!VisibleToRegularObj && Prevailing` is the condition.


http://reviews.llvm.org/D20268