[PATCH] D18826: Add auto-exporting of symbols from tools so that plugins work on Windows

[Sean Silva via llvm-commits]

silvas added inline comments.

================
Comment at: utils/extract_symbols.py:29
@@ +28,3 @@
+def dumpbin_get_symbols(lib):
+    process = subprocess.Popen(['dumpbin','/symbols',lib], bufsize=1,
+                               stdout=subprocess.PIPE, stdin=subprocess.PIPE)
----------------
beanz wrote:
> Rather than calling subprocess.Popen you might consider using subprocess.check_output. It would significantly reduce the amount of boiler plate code in this python script.
Yeah. That's my main comment here too. 


Repository:
  rL LLVM

http://reviews.llvm.org/D18826