[PATCH] D20258: IR: Introduce can_omit_from_dynsym attribute.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri May 13 14:39:47 PDT 2016


As for naming, I would probably name it after what it checks, not what
it is currently used for.

How about making the attribute be just "address_not_used_in_module"?
The other properties (like being linkonce_odr) are easy to check
without having to walk all uses.

Should the verifier check if this the property is invalidly set?

Cheers,
Rafael


On 13 May 2016 at 17:27, Mehdi AMINI <mehdi.amini at apple.com> wrote:
> joker.eph added a comment.
>
> Great, I had in my todo list to look how to move this out of the the object emission to the IR level.
> Any reason for the name change though? The one you came up with does not sound pretty to me, what was wrong with `weak_def_can_be_hidden` or `xxxx_can_be_hidden`?
>
>
> http://reviews.llvm.org/D20258
>
>
>


More information about the llvm-commits mailing list