[PATCH] D12965: [InstCombine] shrink switch conditions better (PR24766)

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Fri May 13 11:32:21 PDT 2016


spatel added a reviewer: sanjoy.
spatel updated this revision to Diff 57224.
spatel added a comment.
Herald added a subscriber: mcrosier.

Patch (finally) updated:
Sorry for letting this sit for so long.
We added the CGP safety harness in http://reviews.llvm.org/D13532 / http://reviews.llvm.org/rL251857 , so we're now free to shrink in InstCombine without regard for the target.

Note that we still don't catch the '9999' case that Nick mentioned in https://llvm.org/bugs/show_bug.cgi?id=24766#c2 ; I think there must be a hole in SimplifyCFG's EliminateDeadSwitchCases() or computeKnownBits() itself. I'll investigate that next.


http://reviews.llvm.org/D12965

Files:
  lib/Transforms/InstCombine/InstructionCombining.cpp
  test/Transforms/InstCombine/narrow-switch.ll
  test/Transforms/InstCombine/pr21651.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12965.57224.patch
Type: text/x-patch
Size: 4670 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160513/e4e6434c/attachment.bin>


More information about the llvm-commits mailing list