[PATCH] D20246: Use full path to clang.exe in LLDB_TEST_COMPILER

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Fri May 13 10:14:38 PDT 2016


zturner created this revision.
zturner added a reviewer: gkistanova.
zturner added a subscriber: llvm-commits.

I basically just copied your code, so this should be correct, but just want to make sure I'm not missing anything.

http://reviews.llvm.org/D20246

Files:
  zorg/buildbot/builders/LLDBBuilder.py

Index: zorg/buildbot/builders/LLDBBuilder.py
===================================================================
--- zorg/buildbot/builders/LLDBBuilder.py
+++ zorg/buildbot/builders/LLDBBuilder.py
@@ -85,6 +85,13 @@
     # Global configurations
     build_dir='build'
 
+    # get full path to build directory
+    f.addStep(SetProperty(name="get_builddir",
+                          command=["pwd"],
+                          property="builddir",
+                          description="set build dir",
+                          workdir="."))
+    
     ############# CLEANING
     cleanBuildRequested = lambda step: step.build.getProperty("clean") or clean
     f.addStep(RemoveDirectory(name='clean '+build_dir,
@@ -96,7 +103,8 @@
 
     # Use batch files instead of ShellCommand directly, Windows quoting is
     # borked. FIXME: See buildbot ticket #595 and buildbot ticket #377.
-    clang_exe = 'bin/clang.exe'    # ./bin/clang.exe
+    clang_exe = WithProperties('%(builddir)s/bin/clang.exe')
+    
     f.addStep(batch_file_download.BatchFileDownload(name='cmakegen',
                                 command=[cmake, "-G", "Ninja", "../llvm",
                                          "-DCMAKE_BUILD_TYPE="+config,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20246.57211.patch
Type: text/x-patch
Size: 1227 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160513/eeaef9ec/attachment.bin>


More information about the llvm-commits mailing list