[PATCH] D17566: *_OPTIONS="help=1" should print to stdout and fit 80 chars width

[Chris Bieneman via llvm-commits]

beanz requested changes to this revision.
beanz added a reviewer: beanz.
beanz added a comment.
This revision now requires changes to proceed.

@marxin The patch relies on the maintainers of compiler-rt to format our text in 80-col limits, then it optionally converts from 80-col to the current formatting.

This patch also only addresses the help output. I'm not very familiar with the GNU conventions, do they apply to the tool output as well?

This imposes burden on our community to conform to another community's coding standards. I believe that is fundamentally unacceptable. It is certainly outside the realms of a discussion for a patch review.

The larger question of whether or not our community should conform to GNU conventions in Compiler-RT (and maintain that conformance) is probably something that would be more appropriate in an LLVM-Dev discussion. That said, I'm violently opposed to enforcing those conventions on our code.

If you want to go down the approach of a compile-time or runtime configuration to conform to GNU conventions that doesn't warrant a larger discussion you'll need to construct the patch in a way that doesn't impose additional burden on the project maintainers.


http://reviews.llvm.org/D17566