[PATCH] D20105: Implement verbose mode in FlieCheck and Lit to capture whole stdin.

[Filipe Cabecinhas via llvm-commits]

filcab added a comment.

Forgot a comment.


================
Comment at: llvm/utils/FileCheck/FileCheck.cpp:1310
@@ +1309,3 @@
+  // Override default value of Verbose
+  if (auto p = std::getenv("LLVM_FILECHECK")) {
+    if (StringRef(p) == "-verbose")
----------------
This should be `LLVM_FILECHECK_OPTIONS` or `LLVM_FILECHECK_EXTRA_ARGS` or something.

================
Comment at: llvm/utils/lit/lit/TestingConfig.py:32
@@ +31,3 @@
+        if extra_pass_vars:
+            pass_vars.extend(extra_pass_vars.split(':'))
+
----------------
When you propose this, please split this to another commit.



Repository:
  rL LLVM

http://reviews.llvm.org/D20105