[PATCH] D20202: [llc] New diagnostic handler

Diana Picus via llvm-commits llvm-commits at lists.llvm.org
Fri May 13 06:54:03 PDT 2016


rovka updated the summary for this revision.
rovka added reviewers: rnk, t.p.northover.
rovka added a subscriber: llvm-commits.
rovka updated this revision to Diff 57169.
rovka added a comment.
Herald added a reviewer: tstellarAMD.
Herald added a subscriber: qcolombet.

Addressed some of the comments.

Added a new llc flag, -exit-on-error (which preserves the old behaviour).

Added -exit-on-error to the tests that fail under the new behaviour.

I also had to specify an underlying integer type for DiagnosticSeverity, so we can forward declare it in LLVMContext.h (otherwise we'd have to include DiagnosticInfo.h, which doesn't seem very nice considering how slender LLVMContext.h is).


http://reviews.llvm.org/D20202

Files:
  include/llvm/IR/DiagnosticInfo.h
  include/llvm/IR/LLVMContext.h
  lib/IR/LLVMContext.cpp
  test/CodeGen/AArch64/arm64-inline-asm-error-I.ll
  test/CodeGen/AArch64/arm64-inline-asm-error-J.ll
  test/CodeGen/AArch64/arm64-inline-asm-error-K.ll
  test/CodeGen/AArch64/arm64-inline-asm-error-L.ll
  test/CodeGen/AArch64/arm64-inline-asm-error-M.ll
  test/CodeGen/AArch64/arm64-inline-asm-error-N.ll
  test/CodeGen/AMDGPU/call.ll
  test/CodeGen/AMDGPU/dynamic_stackalloc.ll
  test/CodeGen/AMDGPU/no-hsa-graphics-shaders.ll
  test/CodeGen/AMDGPU/private-memory-broken.ll
  test/CodeGen/AMDGPU/promote-alloca-bitcast-function.ll
  test/CodeGen/ARM/2012-09-25-InlineAsmScalarToVectorConv2.ll
  test/CodeGen/BPF/many_args1.ll
  test/CodeGen/BPF/many_args2.ll
  test/CodeGen/BPF/struct_ret1.ll
  test/CodeGen/BPF/struct_ret2.ll
  test/CodeGen/MIR/Generic/invalid-jump-table-kind.mir
  test/CodeGen/MIR/Generic/llvm-ir-error-reported.mir
  test/CodeGen/MIR/Generic/machine-function-missing-function.mir
  test/CodeGen/MIR/Generic/machine-function-missing-name.mir
  test/CodeGen/MIR/Generic/machine-function-redefinition-error.mir
  test/CodeGen/MIR/X86/spill-slot-fixed-stack-object-aliased.mir
  test/CodeGen/MIR/X86/spill-slot-fixed-stack-object-immutable.mir
  test/CodeGen/MIR/X86/variable-sized-stack-object-size-error.mir
  test/CodeGen/PowerPC/crbit-asm-disabled.ll
  test/CodeGen/PowerPC/vec-asm-disabled.ll
  test/CodeGen/X86/asm-reject-reg-type-mismatch.ll
  tools/llc/llc.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20202.57169.patch
Type: text/x-patch
Size: 17853 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160513/01b4e9c1/attachment-0001.bin>


More information about the llvm-commits mailing list