[compiler-rt] r269293 - Fixup for r269291, which broke the Go TSan build. Let's not use the symbolizer in Go builds.

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Fri May 13 03:16:17 PDT 2016


On Fri, May 13, 2016 at 12:04 PM, Kuba Brecka <jbrecka at apple.com> wrote:
> Any specific suggestions how to do that for SANITIZER_GO?  Currently,
> SANITIZER_GO isn’t even guaranteed to be “0” or “1”, instead it’s either
> defined or not.  That would be a simple change, but we’ll need to change all
> uses of SANITIZER_GO from #ifdef to #if.

There is kGoMode constant.

> Then it’s still not easy to just “if (SANITIZER_GO)”, because in this case
> (and plenty of others), we’ll just fail to link.  The symbolizer stuff isn't
> built in a Go build.  We *might* be able to link fine with -O<something>
> because the if(0) will be dead-code-removed, but that just makes the
> situation even worse (some configurations build, some don’t).

I don't have a good answer for this one.


More information about the llvm-commits mailing list