[PATCH] D18827: Rework/enhance stack coloring data flow analysis.

Wei Mi via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 17:06:52 PDT 2016


wmi added a comment.

Thanks for the explanation. It makes sense for me now.


================
Comment at: lib/CodeGen/StackColoring.cpp:531
@@ +530,3 @@
+          if (! BetweenStartEnd.test(Slot)) {
+            DegenerateSlots.set(Slot);
+          }
----------------
should we add an assertion "!MI.mayLoad() && !MI.mayStore()" so if weird escaped reference case does exist, they will be caught at compile time?


http://reviews.llvm.org/D18827





More information about the llvm-commits mailing list