[PATCH] D17740: [PPC, SSP] Support PowerPC Linux stack protection using LOAD_STACK_GUARD

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 16:30:36 PDT 2016


> On May 12, 2016, at 4:27 PM, Marcin Koƛcielnicki via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> On 13/05/16 01:26, David Blaikie via llvm-commits wrote:
>> Did this get committed? I can't seem to find the subject line anywhere &
>> the Differential revision isn't mentioned in a commit that I can find, etc.
>> 
> 
> It was commited as 266809.

For future revision: it is a good practice to add the commit id as a comment when closing a revision in Phabricator.

Thanks!

-- 
Mehdi


> 
>> On Tue, Apr 19, 2016 at 1:19 PM, Tim Shen via llvm-commits
>> <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>> 
>>    timshen added inline comments.
>> 
>>    ================
>>    Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:12017
>>    @@ +12016,3 @@
>>    +
>>    +// Override to enable LOAD_STACK_GUARD lowering on Linux.
>>    +bool PPCTargetLowering::useLoadStackGuardNode() const {
>>    ----------------
>>    s/simplifies/simplified/. Apparently my English is broken. :P
>> 
>> 
>>    http://reviews.llvm.org/D17740
>> 
>> 
>> 
>>    _______________________________________________
>>    llvm-commits mailing list
>>    llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>>    http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>> 
>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list