[PATCH] D20147: [WIP] DebugInfo: New metadata representation for global variables.

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 15:39:43 PDT 2016


> On 2016-May-11, at 13:14, Adrian Prantl <aprantl at apple.com> wrote:
> 
>> I'm not changing the relationship between DICompileUnit and DIGlobalVariable in this patch. This means that if we change the DIExpression, we'd most likely need to find the DIGlobalVariable in the DICompileUnit's global list and rewrite it. But I suppose that's fine if it's temporary.
> 
> 
> Agreed, that sounds not so great. Would it be possible to change the relationship before landing this patch?

Note that if a DIGlobalVariable is "distinct", it's also fine to rewrite it.  I think I made the change on trunk a couple of weeks ago, but if not, it shouldn't be hard (just a change in DIBuilder.cpp).


More information about the llvm-commits mailing list