[compiler-rt] r263160 - [Windows] Fix UnmapOrDie and MmapAlignedOrDie

[Reid Kleckner via llvm-commits]

On Thu, May 12, 2016 at 11:30 AM, Dmitry Vyukov <dvyukov at google.com> wrote:
> There is one other case where tsan uses FlushUnneededShadowMemory for
> a middle of a mapping. It's empty on windows, so it "works".
>
> I will look into making something more sane for traces.

Thanks, sounds good.

>> I wanted to find a way to test building tsan on Windows, but from
>> lib/tsan/go/build.bat it looks like it only supports a unity-style
>> mingw gcc build, and then I can't run any tests without a go
>> implementation. There's no need to port tsan to build with MSVC, but
>> it would be nice if I could build and test it with mingw and cmake.
>
> Yes, there is a problem with testing.
>
> Build requires a 64-bit mingw gcc (not provided by official
> distribution last time I checked) and a Go checkout on a particular
> revision.
> Is it possible to upload binary blobs with gcc and Go onto windows
> bots? Do we already have some bat script where I can add Go testing?
> Can you give me RDC access to a windows machine for testing?
>
> ... and tests will be broken for some periods because lots of changes
> require updating both tsan runtime and Go side which is not possible
> to do atomically.

We have a Windows VM but no existing shell script you can hook into:
http://lab.llvm.org:8011/builders/sanitizer-windows/

It sounds like we can add tsan testing when we convert that over to
buildbot annotations like the other sanitizer bots.