[llvm] r269251 - [ThinLTO] Don't re-analyze callee at same threshold unnecessarily

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Wed May 11 15:56:20 PDT 2016


Author: tejohnson
Date: Wed May 11 17:56:19 2016
New Revision: 269251

URL: http://llvm.org/viewvc/llvm-project?rev=269251&view=rev
Log:
[ThinLTO] Don't re-analyze callee at same threshold unnecessarily

This should just be a compile-time change. Correct the check for whether
we have already analyzed the callee when making summary based decisions.
There is no need to reprocess one at the same threshold as when it was
last processed.

Modified:
    llvm/trunk/lib/Transforms/IPO/FunctionImport.cpp

Modified: llvm/trunk/lib/Transforms/IPO/FunctionImport.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/FunctionImport.cpp?rev=269251&r1=269250&r2=269251&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/IPO/FunctionImport.cpp (original)
+++ llvm/trunk/lib/Transforms/IPO/FunctionImport.cpp Wed May 11 17:56:19 2016
@@ -288,7 +288,7 @@ static void computeImportForFunction(
     /// Since the traversal of the call graph is DFS, we can revisit a function
     /// a second time with a higher threshold. In this case, it is added back to
     /// the worklist with the new threshold.
-    if (ProcessedThreshold && ProcessedThreshold > Threshold) {
+    if (ProcessedThreshold && ProcessedThreshold >= Threshold) {
       DEBUG(dbgs() << "ignored! Target was already seen with Threshold "
                    << ProcessedThreshold << "\n");
       continue;




More information about the llvm-commits mailing list