[PATCH] D19961: [LSAN] Fix test swapcontext.cc on MIPS

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Wed May 11 15:39:37 PDT 2016


aizatsky added a subscriber: aizatsky.

================
Comment at: lib/lsan/lsan.h:18
@@ -17,1 +17,3 @@
 
+#if defined(__mips__)
+#define GET_STACK_TRACE(max_size, fast)                                        \
----------------
We try to stay away from platform ifdefs where possible. Especially here, where new define follows the other one almost to the letter.

I suggest you find a way to achieve this without platform ifdefs. (e.g. function differently defined in platform-specific files).


Repository:
  rL LLVM

http://reviews.llvm.org/D19961





More information about the llvm-commits mailing list