[PATCH] D20153: [ARM] PR25722 Delay ARM constant pool creation

[Tim Northover via llvm-commits]

t.p.northover added a comment.

Hi Peter,

Good to see you around the LLVM lists! This change mostly looks good to me, just one comment really:


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:6892
@@ +6891,3 @@
+    TmpInst.addOperand(MCOperand::createExpr(CPLoc)); // Offset to pool
+    if (Inst.getOpcode() == ARM::LDRConstPool)
+      TmpInst.addOperand(MCOperand::createImm(0));    // ARM uses two operands
----------------
You change this line in D20155. It would seem sensible to either do it here or not at all.


http://reviews.llvm.org/D20153