[PATCH] D20138: Refactor CodeView TypeRecord visitors to use common structures

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed May 11 08:36:46 PDT 2016


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm with one last fix


================
Comment at: include/llvm/DebugInfo/CodeView/TypeRecord.h:697
@@ +696,3 @@
+    if (Props & uint16_t(ClassOptions::HasUniqueName)) {
+      UniqueName = StringRef(reinterpret_cast<const char *>(Data.data()));
+      Data = Data.slice(UniqueName.size() + 1);
----------------
What about this though?


http://reviews.llvm.org/D20138





More information about the llvm-commits mailing list