[PATCH] D20067: Error if inline assembly ends in unexpected mode

[Nirav Dave via llvm-commits]

niravd added a comment.

> Changing ARM to emit an error or an on-by-default warning may break builds that didn't break before. Maybe a -Wall warning would be better? How does gcc handle this?


I warning would be reasonable, but given GCC just inlines the assembly text which strikes me as them implicitly claiming this as ill-formed input as neither GCC nor clang with -fno-integrated-as have no way to ensure meaning propagation of mode changes past inline assembly, I'm leaning towards asserting a full on error over issuing a warning.

> [1] http://reviews.llvm.org/D2255


I'll add the folks on http://reviews.llvm.org/D2255 and see what they think.


http://reviews.llvm.org/D20067