[PATCH] D19373: Remangle intrinsics names when types are renamed

Artur Pilipenko via llvm-commits llvm-commits at lists.llvm.org
Wed May 11 05:04:24 PDT 2016


apilipenko added a comment.

@reames, your suggestion to move the logic to upgradeIntrinsicFunction is basically what I had in the first diff of the review. But there was an argument to avoid using autoupgarde for cases which are technically not upgrade, i.e. for the IR generated by the same version of LLVM.


================
Comment at: lib/AsmParser/LLParser.cpp:222
@@ +221,3 @@
+      for (User *U : F->users())
+        if (CallInst *CI = dyn_cast<CallInst>(U))
+          CI->setCalledFunction(Remangled.getValue());
----------------
reames wrote:
> You can also invoke some intrinsics.  Use CallSite or handle InvokeInst.
Good catch, will fix.


http://reviews.llvm.org/D19373





More information about the llvm-commits mailing list