[PATCH] D19410: [scan-build] fix warnings emitted on LLVM ARM code base

[Apelete Seketeli via llvm-commits]

apelete updated this revision to Diff 56857.
apelete added a comment.

[scan-build] fix warnings emitted on LLVM ARM code base

Changes since last revision:

- lib/Target/ARM/MCTargetDesc/ARMMachObjectWriter.cpp: remove the changes in this file since they break the following tests:

  Failing Tests (25): LLVM :: CodeGen/ARM/2011-01-19-MergedGlobalDbg.ll LLVM :: CodeGen/ARM/2011-08-02-MergedGlobalDbg.ll LLVM :: CodeGen/ARM/debug-info-blocks.ll LLVM :: CodeGen/ARM/debug-info-sreg2.ll LLVM :: CodeGen/ARM/local-call.ll LLVM :: CodeGen/ARM/none-macho.ll LLVM :: CodeGen/ARM/thumb1-varalloc.ll LLVM :: CodeGen/Thumb2/constant-islands.ll LLVM :: DebugInfo/ARM/bitfield.ll LLVM :: DebugInfo/ARM/s-super-register.ll LLVM :: DebugInfo/ARM/split-complex.ll LLVM :: LTO/ARM/runtime-library-subtarget.ll LLVM :: MC/ARM/aligned-blx.s LLVM :: MC/ARM/macho-movwt.s LLVM :: MC/ARM/misaligned-blx.s LLVM :: MC/ARM/thumb1-relax-br.s LLVM :: MC/ARM/tls-directives.s LLVM :: MC/MachO/ARM/aliased-symbols.s LLVM :: MC/MachO/ARM/compact-unwind-armv7k.s LLVM :: MC/MachO/ARM/darwin-ARM-reloc.s LLVM :: MC/MachO/ARM/darwin-Thumb-reloc.s LLVM :: MC/MachO/ARM/long-call-branch-island-relocation.s LLVM :: MC/MachO/ARM/static-movt-relocs.s LLVM :: MC/MachO/ARM/thumb-bl-jbits.s LLVM :: MC/MachO/ARM/thumb2-movw-fixup.s


http://reviews.llvm.org/D19410

Files:
  lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  lib/Target/ARM/Thumb2SizeReduction.cpp

Index: lib/Target/ARM/Thumb2SizeReduction.cpp
===================================================================
--- lib/Target/ARM/Thumb2SizeReduction.cpp
+++ lib/Target/ARM/Thumb2SizeReduction.cpp
@@ -988,7 +988,7 @@
         NextMII->bundleWithPred();
     }
 
-    if (!NextInSameBundle && MI->isInsideBundle()) {
+    if (BundleMI && !NextInSameBundle && MI->isInsideBundle()) {
       // FIXME: Since post-ra scheduler operates on bundles, the CPSR kill
       // marker is only on the BUNDLE instruction. Process the BUNDLE
       // instruction as we finish with the bundled instruction to work around
Index: lib/Target/ARM/AsmParser/ARMAsmParser.cpp
===================================================================
--- lib/Target/ARM/AsmParser/ARMAsmParser.cpp
+++ lib/Target/ARM/AsmParser/ARMAsmParser.cpp
@@ -9961,7 +9961,9 @@
     return true;
 
   // '.align' is target specifically handled to mean 2**2 byte alignment.
-  if (getStreamer().getCurrentSection().first->UseCodeAlign())
+  const MCSection *Section = getStreamer().getCurrentSection().first;
+  assert(Section && "must have section to emit alignment");
+  if (Section->UseCodeAlign())
     getStreamer().EmitCodeAlignment(4, 0);
   else
     getStreamer().EmitValueToAlignment(4, 0, 1, 0);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19410.56857.patch
Type: text/x-patch
Size: 1270 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160511/764c82cc/attachment.bin>