[PATCH] D13741: Introduce a *draft* of a code of conduct for the LLVM community and theassociated reporting guide.

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 21:45:36 PDT 2016


sanjoy added a subscriber: sanjoy.
sanjoy accepted this revision.
sanjoy added a reviewer: sanjoy.
sanjoy added a comment.

This is looking great.  I made a few nitpicks while reading, feel free to pick and choose.


================
Comment at: docs/CodeOfConduct.rst:31
@@ +30,3 @@
+you say, slides, videos, posters, signs, or even t-shirts you display in these
+spaces. In addition, violations of this code outside these spaces may, in rare
+cases, affect a person's ability to participate within them.
----------------
I'm not sure why "In addition" is needed?  In addition to what else in the preceding paragraph?

================
Comment at: docs/CodeOfConduct.rst:55
@@ +54,3 @@
+  will depend on the work of others. Any decision you take will affect users
+  and colleagues, and you should take those consequences into account when
+  making decisions. Remember that we're a world-wide community, so you might
----------------
I'd prefer removing "when making decisions", since that looks like it is repeated.

================
Comment at: docs/CodeOfConduct.rst:85
@@ +84,3 @@
+  In general, if someone asks you to stop, then stop. Persisting in such
+  a behavior after being asked to stop is considered harassment.
+
----------------
I'd s/a behavior/behavior/

================
Comment at: docs/CodeOfConduct.rst:92
@@ +91,3 @@
+  we resolve disagreements and differing views constructively. Remember that
+  we’re different. The strength of LLVM comes from its varied community, people
+  from a wide range of backgrounds. Different people have different
----------------
"we're diverse" seems more specific

================
Comment at: docs/ReportingGuide.rst:36
@@ +35,3 @@
+   enforcement within the community. They provide avenues for handling severe
+   cases or cases where the reporting party does not whish to respond directly
+   for any reason.
----------------
spelling: wish

================
Comment at: docs/ReportingGuide.rst:46
@@ +45,3 @@
+
+* Your contact info (so we can get in touch with you if we need to follow up)
+* Names (real, nicknames, or pseudonyms) of any individuals involved. If there
----------------
Nit: period at the end (or remove periods from all bullets)

================
Comment at: docs/ReportingGuide.rst:60
@@ +59,3 @@
+You will receive an email from the advisory committee acknowledging receipt
+within 24 hours (and we will aim to respond much quicker than that).
+
----------------
s/we/the advisory committee/ (or consistently refer to the committee as the first person)


http://reviews.llvm.org/D13741





More information about the llvm-commits mailing list