[PATCH] D19922: [AArch64] Fix DAG selection for cmps for fp16 type

Weiming Zhao via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 18:38:53 PDT 2016


weimingz added a comment.

Thank you, Tim! And do we need to guard the promotion of fp16->fp32 with !HasFullFP16() check? If some subtarget has full  fp16 support, the promotion is not needed, is it?


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:1412
@@ -1411,3 +1411,3 @@
     SDValue LHS = Val->getOperand(0);
     SDValue RHS = Val->getOperand(1);
     ISD::CondCode CC = cast<CondCodeSDNode>(Val->getOperand(2))->get();
----------------
Operands get from a chained SETCC


Repository:
  rL LLVM

http://reviews.llvm.org/D19922





More information about the llvm-commits mailing list