[PATCH] D20115: Loop unroller: set thresholds for optsize and minsize functions to zero

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 14:51:38 PDT 2016


hans added a comment.

In http://reviews.llvm.org/D20115#426439, @mzolotukhin wrote:

> Thanks, this looks good to me. In terms of performance and code size/compile time this patch should only restore the behavior before r268509, right?


For performance and code size, yes, this just restores the behaviour with Clang before r268509 (except for code with unroll pragmas). For compile time, we didn't use to have this pass in the pipeline at all before, so even with the threshold set to zero there is probably some cost.


================
Comment at: test/Transforms/LoopUnroll/unroll-opt-attribute.ll:110
@@ -138,4 +109,3 @@
 
-; This test shows that with optsize attribute, this loop is not unrolled 
-; by default.
+; This test shows that with optsize attribute, this loop is not unrolled .
 
----------------
mzolotukhin wrote:
> Redundant space in the end.
Will fix when committing, thanks.


http://reviews.llvm.org/D20115





More information about the llvm-commits mailing list