[PATCH] D20083: Add an c++ itanium demangler to llvm

[Sean Silva via llvm-commits]

silvas added a subscriber: silvas.
silvas added a comment.

Small nit.


================
Comment at: include/llvm/Demangle/Demangle.h:13
@@ +12,3 @@
+namespace llvm {
+char *itanium_demangle(const char *mangled_name, char *buf, size_t *n,
+                       int *status);
----------------
Can you add some docs for the arguments and return.
Especially these questions jump out to me:
- what is the return value? If we demangle into `buf` then wouldn't the demangled name be implicitly be at the beginning of `buf`?
- what is `status`? Is it just 0/1?


http://reviews.llvm.org/D20083