[PATCH] D19921: [esan] EfficiencySanitizer shadow memory

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 16:13:47 PDT 2016


aizatsky added inline comments.

================
Comment at: lib/esan/esan_shadow.h:79
@@ +78,3 @@
+//
+// We also want to ensure that a wild access by the application into the shadow
+// regions will not corrupt our own shadow memory.  shadow(shadow) ends up
----------------
The protection from this kind of wild access adds significant complexity to the mapping scheme. Is it really important for esan? 

I can imagine this being important for asan, even though it seems to ignore this issue atm. Do we really need this complexity?


http://reviews.llvm.org/D19921





More information about the llvm-commits mailing list